Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI ephemeral volume alpha documentation #15055

Merged
merged 1 commit into from
Jun 25, 2019
Merged

CSI ephemeral volume alpha documentation #15055

merged 1 commit into from
Jun 25, 2019

Conversation

vladimirvivien
Copy link
Member

Doc PR resubmitted for CSI ephemeral inline volume alpha feature.

Original doc got dropped during 1.15 doc release (#14984)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 21, 2019
@netlify
Copy link

netlify bot commented Jun 21, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit bb7ce10

https://deploy-preview-15055--kubernetes-io-master-staging.netlify.com

@msau42
Copy link
Member

msau42 commented Jun 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2019
@jimangel
Copy link
Member

/hold

Something is funky:

  • @vladimirvivien indicated that the work was already there (but I saw, with my eyes, a commit of @makoscafee removing it).
  • After this PR landed, there was STILL conflict on the single file.
    • I'm assuming @vladimirvivien used a fresh fetch / copy and worked off of master (please confirm)?
  • Initially, I thought, "no big deal, I'll resolve the conflict and we can get this in."
    • This involved confirming we want to keep the CSI content.
    • After committing my resolution, it brought all of @makoscafee's changes in: 31fe090

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2019
@vladimirvivien
Copy link
Member Author

@jimangel
Yes, I refreshed off master. It looks like master got cleaned up which means an update to this PR with the correct content should work.

@vladimirvivien
Copy link
Member Author

@jimangel
I rebased against master, checked content, and this should be good to go.

@vladimirvivien
Copy link
Member Author

/remove-hold

@vladimirvivien
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2019
@vladimirvivien
Copy link
Member Author

@jimangel PTAL

@makoscafee
Copy link
Contributor

/LGTM
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makoscafee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit c7deda4 into kubernetes:master Jun 25, 2019
joaovitor pushed a commit to joaovitor/website that referenced this pull request Jul 5, 2019
@vladimirvivien @joaovitor
CSI ephemeral volume alpha documentation (kubernetes#15055)
c0879c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@makoscafee makoscafee

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vladimirvivien @msau42 @jimangel @makoscafee @k8s-ci-robot